llama : fix qs.n_attention_wv for DeepSeek-V2 #9156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compilade
added
bugfix
|
@compilade Tested it and works, was able to quantize and run the model on ollama. |
ggerganov
approved these changes
Aug 26, 2024
|
@ggerganov |
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #9155
This previously (before #8526) did not trigger the assertion because a value of
0was accepted for recurrent models, but DeepSeek-V2(-Lite) is not a recurrent model.Counting either
attn_kv_a_mqa.weightorattn_kv_b.weightshould fix this, but I went with the shorter of the two to fit vertically with the other conditions in theifwhich counts those tensors.@mann1x can you confirm whether or not this fixes the problem?